openvi: init at 7.3.22 #230014
Merged
openvi: init at 7.3.22 #230014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wegank
reviewed
May 5, 2023
wegank
reviewed
May 5, 2023
|
Done. |
This comment was marked as resolved.
This comment was marked as resolved.
wegank
approved these changes
May 5, 2023
|
The GNUmakefile installs them to correct path, is there a need to still use |
wegank
reviewed
May 5, 2023
|
|
||
| makeFlags = [ | ||
| "PREFIX=$(out)" | ||
| # command -p will yield command not found erorr |
There was a problem hiding this comment.
Suggested change
| # command -p will yield command not found erorr | |
| # command -p will yield command not found error |
There was a problem hiding this comment.
I'm just outside 🥲 will fix in next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Yet another vi editor in this repo, ported from OpenBSD, hope someone enjoy it :3
https://github.com/johnsonjh/OpenVi
The result does contain a few manpages, but sadly when I tried to add
outputs = [ "out" "man" ];it gave mepop_var_context: head of shell_variables not a function context. So I gave up on it.I also didn't add
mainProgrambecause the result contains three executables:oex,oviandoview, just like the situation with nvi.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)