Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sway: module #23030

Closed
wants to merge 1 commit into from
Closed

Sway: module #23030

wants to merge 1 commit into from

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Feb 20, 2017

Motivation for this change

Adds service module for the swaywm

Things done
  • [x ] Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [ n/a] Tested execution of all binary files (usually in ./result/bin/)
  • [x ] Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @bjornfor and @offlinehacker to be potential reviewers.

@ndowens
Copy link
Contributor Author

ndowens commented Feb 20, 2017

Tested it in VM, either leaving out the configFile option out or not having i3 installed, seems to make sway work, atleast a bit. Couldn't get terminator or firefox to load for some reason, but may not be related to this module?

@ndowens ndowens changed the title Swaywm: module Sway: module Feb 21, 2017
@@ -542,6 +542,7 @@
./services/web-servers/apache-httpd/default.nix
./services/web-servers/caddy.nix
./services/web-servers/fcgiwrap.nix
./services/web-servers/hiawatha.nix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line shouldn't be part of this PR,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that line is there. I branched off to separate 😀 Will do when I get home

'';
};
};
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the indention of the options.

'';
}];
environment.systemPackages = [ pkgs.sway ];
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indention is also pretty wild here.

@ndowens
Copy link
Contributor Author

ndowens commented Feb 21, 2017

@fpletz gonna close this and create another PR, tried updating the commit but it didnt seem to do anygood

@ndowens ndowens closed this Feb 21, 2017
@ndowens ndowens deleted the sway_module branch February 21, 2017 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants