Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libbpf: add some key reverse dependencies to passthru.tests #230368

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

risicle
Copy link
Contributor

@risicle risicle commented May 6, 2023

Description of changes

Another package with too many reverse dependencies to sensibly nixpkgs-review in full.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@risicle risicle changed the title libbpf: add some key reverse dependencies to passthru.tests libbpf: add some key reverse dependencies to passthru.tests May 6, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2699

Copy link
Member

@martinetd martinetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why maintainers didn't get pinged by ofborg -- a bit late to the party but LGTM, these pretty much are the packages we'd want to test.

(note to self: pahole and linux will also get rebuilt through nixosTests.bpf as it needs pahole to build linux, and needs linux to start the test VM)

@SuperSandro2000 SuperSandro2000 merged commit f35ab6d into NixOS:master Jan 28, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants