stdenv: wrap phase running actions of genericBuild #230874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Artturin
reviewed
Nov 7, 2023
pkgs/stdenv/generic/setup.sh
Outdated
| @@ -1539,6 +1539,44 @@ showPhaseFooter() { | |||
| } | |||
|
|
|||
|
|
|||
| runPhase() { | |||
| local curPhase="${1%Phase}Phase" | |||
Provide a `runPhase` function which wraps the phase running action of genericBuild. The new function can be used as an interface by `nix develop`, i.e. `nix develop some#flake --build` may just call `runPhase build`, which makes its behavior more consistent with `nix build`. In preparation of fixing NixOS/nix#6202
Artturin
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
hello> somePhase
hello> build failed in somePhase with exit code 1
hello> To attach install cntr and run the following command as root:
hello> cntr attach -t command cntr-/nix/store/x82brk9g33fhnq33nwb9hl6s2zqmfzzh-hello-2.12.1
diff --git a/pkgs/by-name/he/hello/package.nix b/pkgs/by-name/he/hello/package.nix
index f1b056faf640..c632ba1e9835 100644
--- a/pkgs/by-name/he/hello/package.nix
+++ b/pkgs/by-name/he/hello/package.nix
@@ -5,6 +5,7 @@
, nixos
, testers
, hello
+, breakpointHook
}:
stdenv.mkDerivation (finalAttrs: {
@@ -28,6 +29,14 @@ stdenv.mkDerivation (finalAttrs: {
(nixos { environment.noXlibs = true; }).pkgs.hello;
};
+ nativeBuildInputs = [ breakpointHook ];
+
+ buildPhase = ''
+ runPhase somePhase
+ '';
+
+ somePhase = ''exit 1'';
+
passthru.tests.run = callPackage ./test.nix { hello = finalAttrs.finalPackage; };
meta = with lib; {breakpointHook uses $curPhase and it works
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/nix-build-phases-run-nix-build-phases-interactively/36090/4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a
runPhasefunction which wraps the phase running action of genericBuild. The new function can be used as an interface bynix develop, i.e.nix develop some#flake --buildmay just callrunPhase build, which makes its behavior more consistent withnix build. In preparation of fixing NixOS/nix#6202Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)