Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release(-lib).nix: optionally allow building unfree packages #23243

Closed
wants to merge 1 commit into from

Conversation

bjornfor
Copy link
Contributor

I'd like to create a personal nixpkgs channel containing some unfree
packages. This adds 'allowUnfree' parameter so that more of the release
infrastructure can be reused.

The default is still to not build unfree packages, so for nixpkgs this
is no functional change.

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I'd like to create a personal nixpkgs channel containing some unfree
packages. This adds 'allowUnfree' parameter so that more of the release
infrastructure can be reused.

The default is still to not build unfree packages, so for nixpkgs this
is no functional change.
@mention-bot
Copy link

@bjornfor, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @domenkozar and @rbvermaa to be potential reviewers.

@bennofs
Copy link
Contributor

bennofs commented Feb 27, 2017

Perhaps we should just allow passing in a config arg? This would cover more usecases than just this one.

@bjornfor
Copy link
Contributor Author

Good point.

Should we go further? We could pass an arbitrary attrset, so that e.g. overlays can be specified too?

...
, nixpkgsArgs ? { config = { allowUnfree = false; inHydra = true; }; }

@bjornfor bjornfor closed this Feb 28, 2017
@bjornfor bjornfor deleted the optionally-allow-unfree branch April 11, 2017 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants