Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qutebrowser: 0.9.1 -> 0.10.0 [WIP] #23244

Closed
wants to merge 0 commits into from
Closed

qutebrowser: 0.9.1 -> 0.10.0 [WIP] #23244

wants to merge 0 commits into from

Conversation

NickHu
Copy link
Contributor

@NickHu NickHu commented Feb 27, 2017

Motivation for this change

Update qutebrowser to the latest version.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@NickHu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar, @FRidh and @kirelagin to be potential reviewers.

@NickHu
Copy link
Contributor Author

NickHu commented Feb 27, 2017

Webengine seems to be broken with this version for some reason, I get the following error when trying to launch with qutebrowser --backend webengine:

17:14:44 CRITICAL: Could not find QtWebEngineProcess
  File "/nix/store/nd3xizpas6ghi6jgp6k9g8vara7cynxc-qutebrowser-0.10.0/bin/..qutebrowser-wrapped-wrapped", line 12, in <module>
    sys.exit(main())
  File "/nix/store/nd3xizpas6ghi6jgp6k9g8vara7cynxc-qutebrowser-0.10.0/lib/python3.5/site-packages/qutebrowser/qutebrowser.py", line 169, in main
    return app.run(args)
  File "/nix/store/nd3xizpas6ghi6jgp6k9g8vara7cynxc-qutebrowser-0.10.0/lib/python3.5/site-packages/qutebrowser/app.py", line 112, in run
    init(args, crash_handler)
  File "/nix/store/nd3xizpas6ghi6jgp6k9g8vara7cynxc-qutebrowser-0.10.0/lib/python3.5/site-packages/qutebrowser/app.py", line 139, in init
    _init_modules(args, crash_handler)
  File "/nix/store/nd3xizpas6ghi6jgp6k9g8vara7cynxc-qutebrowser-0.10.0/lib/python3.5/site-packages/qutebrowser/app.py", line 418, in _init_modules
    websettings.init(args)
  File "/nix/store/nd3xizpas6ghi6jgp6k9g8vara7cynxc-qutebrowser-0.10.0/lib/python3.5/site-packages/qutebrowser/config/websettings.py", line 266, in init
    from qutebrowser.browser.webengine import webenginesettings
  File "<frozen importlib._bootstrap>", line 1016, in _handle_fromlist
  File "<frozen importlib._bootstrap>", line 222, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 969, in _find_and_load
  File "<frozen importlib._bootstrap>", line 958, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 673, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 673, in exec_module
  File "<frozen importlib._bootstrap>", line 222, in _call_with_frames_removed
  File "/nix/store/nd3xizpas6ghi6jgp6k9g8vara7cynxc-qutebrowser-0.10.0/lib/python3.5/site-packages/qutebrowser/browser/webengine/webenginesettings.py", line 272, in <module>
    setter=setHttpCacheMaximumSize)
  File "/nix/store/nd3xizpas6ghi6jgp6k9g8vara7cynxc-qutebrowser-0.10.0/lib/python3.5/site-packages/qutebrowser/browser/webengine/webenginesettings.py", line 74, in __init__
    profile = QWebEngineProfile.defaultProfile()
  File "/nix/store/nd3xizpas6ghi6jgp6k9g8vara7cynxc-qutebrowser-0.10.0/lib/python3.5/site-packages/qutebrowser/utils/log.py", line 459, in qt_message_handler
    stack = '.join(traceback.format_stack())

[1]    11430 abort      qutebrowser --backend webengine

I can't figure out what's going on here, but previously with webengine all Google domains had SSL errors and refused to load (ref qutebrowser/qutebrowser#2319).

@peterhoeg
Copy link
Member

Couple of things:

  • do not update multiple things in the same commit and it would make sense to do the python modules in separate PRs so we can check if that breaks anything else.
  • qt57.callPackage has changed as of yesterday, which is why you have merge conflicts against master, but everything is OK against nixos-unstable. You can read more here: http://lists.science.uu.nl/pipermail/nix-dev/2017-February/022900.html

Just out of curiosity, with pyqt5 5.8, does qutebrowser still segfault on exit?

@NickHu
Copy link
Contributor Author

NickHu commented Mar 4, 2017

I've separated updating the dependencies to two different pull requests:

I'll update this one when they get merged.
Yes, it still segfaults on exit.

@abbradar
Copy link
Member

It wasn't merged yet, why close this?

@NickHu
Copy link
Contributor Author

NickHu commented Mar 10, 2017

Sorry, I closed it because I'm preparing a pr to update to 0.10.1 instead, which was released two days ago - just building it to see that it compiles first.

@NickHu
Copy link
Contributor Author

NickHu commented Mar 10, 2017

Closed in favour of #23724.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants