Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/lemmy: support nginx #232536

Merged
merged 1 commit into from Jun 12, 2023
Merged

Conversation

uninsane
Copy link
Contributor

Description of changes

allows users to deploy lemmy as a nginx virtual host. for example:

{
  services.lemmy = {
    enable = true;
    settings.hostname = "lemmy.mydomain.tld";
    # tell nginx to proxy the above hostname to lemmy
    nginx.enable = true;
  };
}

services.lemmy.nginx.enable aims to be equivalent to the existing services.lemmy.caddy.enable option.

for a complete lemmy/nginx deployment on NixOS, see:

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@happysalada
Copy link
Contributor

I dont know nginx very well, but these changes look good to me. Im waiting 24h to give bill time to see these changes.

Copy link
Contributor

@icewind1991 icewind1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with my local instance, all looks good

@happysalada happysalada merged commit bd77d4a into NixOS:master Jun 12, 2023
18 checks passed
@happysalada
Copy link
Contributor

@uninsane thank you! Feel free to ping me for any rust related tooling (in case you don't have someone in particular in mind for review).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants