Ensime #23256
Merged
Ensime #23256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows vim plugins to specify python dependencies required at runtime, and they will be added to the python environment.
|
@edanaher, thanks for your PR! By analyzing the history of the files in this pull request, we identified @garbas, @jagajaga and @MarcWeber to be potential reviewers. |
edanaher
referenced
this pull request
Mar 18, 2017
Not sure at all if this is the right thing to do. cc @edanaher
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I'd like to be able to use ensime from vim, hence the additional plugin.
However, using it requires a couple python packages to be available. Initially I added them as extraPythonPackages in my config.nix, but it wasn't that much more work to add the logic to make neovim automatically pull them in, which is much more user-friendly. Hopefully my additions are reasonable.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)