logcheck: 1.3.17 -> 1.3.18 #23317
logcheck: 1.3.17 -> 1.3.18 #23317
Conversation
|
@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bluescreen303, @pSub and @Phreedom to be potential reviewers. |
|
The corresponding module seems to be broken: This module also still uses cron instead of systemd timer. |
| version = "1.3.17"; | ||
| name = "${_name}-${version}"; | ||
| version = "1.3.18"; | ||
| name = "logcheck_${version}"; |
There was a problem hiding this comment.
Unfortunately the hyphen here is actually important.
There was a problem hiding this comment.
The _ is correct. http://http.debian.net/debian/pool/main/l/logcheck/logcheck_1.3.18.tar.xz is the source from Debian
There was a problem hiding this comment.
The hyphen is needed for Nix to know what part of "name" is the package name and what is the version number.
There was a problem hiding this comment.
Debian always uses _ to desperate program name, version and architecture in file names. Even for the original source tarballs they provide.
|
Hmm that is weird but ok.
…Sent from my iphone
On Mar 2, 2017, 3:20 PM -0600, Bjørn Forsman ***@***.***>, wrote:
@bjornfor commented on this pull request.
In pkgs/tools/system/logcheck/default.nix (#23317 (comment)):
> @@ -1,13 +1,12 @@ { stdenv, fetchurl, lockfileProgs, perl, mimeConstruct }: stdenv.mkDerivation rec { - _name = "logcheck"; - version = "1.3.17"; - name = "${_name}-${version}"; + version = "1.3.18"; + name = "logcheck_${version}";
The hyphen is needed for Nix to know what part of "name" is the package name and what is the version number.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (#23317 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAHL77yn7aS_V_7gw6RMqVanyYiO8CANks5rhzKGgaJpZM4MPIfJ).
|
logcheck: Added hyphen
|
@Mic92 I will try to look at the module too. Even though just trying to update packages to latestbin repo 👅 |
|
@Mic92 I don't think I can fix the logcheck module, as I don't really understand it greatly |
Motivation for this change
Update
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)