Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests/nar-serve: Fix #234116

Merged
merged 1 commit into from May 26, 2023
Merged

nixos/tests/nar-serve: Fix #234116

merged 1 commit into from May 26, 2023

Conversation

chkno
Copy link
Member

@chkno chkno commented May 26, 2023

Description of changes

Fix one of the two problems with this test: It's currently failing due to a missing python import.

The other problem is an upstream regression, and needs to be fixed upstream

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@wegank
Copy link
Member

wegank commented May 26, 2023

@ofborg test nar-serve

@wegank wegank merged commit 9b6c126 into NixOS:master May 26, 2023
21 of 23 checks passed
@kilianar kilianar mentioned this pull request May 28, 2023
13 tasks
@chkno chkno deleted the nar-serve-fix branch May 31, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants