Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noson: init at 5.4.1 #234210

Merged
merged 1 commit into from Jun 1, 2023
Merged

noson: init at 5.4.1 #234210

merged 1 commit into from Jun 1, 2023

Conversation

callahad
Copy link
Member

Description of changes

Add Noson, a Sonos speaker controller, to Nixpkgs

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

pkgs/applications/audio/noson/default.nix Outdated Show resolved Hide resolved
drupol

This comment was marked as outdated.

@callahad
Copy link
Member Author

It's a bit wonky (originally designed for SailfishOS?), but it works well enough to be useful :)

drupol

This comment was marked as outdated.

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-in-distress/3604/61

@drupol drupol merged commit f8213a3 into NixOS:master Jun 1, 2023
21 checks passed
@callahad callahad deleted the noson branch June 1, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants