Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnu-efi: 3.0.17 -> 3.0.15 #234796

Closed
wants to merge 1 commit into from
Closed

Conversation

wegank
Copy link
Member

@wegank wegank commented May 29, 2023

Description of changes

Reverts #230601.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@wegank wegank requested a review from vcunat May 29, 2023 12:44
@wegank
Copy link
Member Author

wegank commented May 29, 2023

@ofborg build efitools

@vcunat
Copy link
Member

vcunat commented May 29, 2023

Uh, 33k rebuilds.

@vcunat
Copy link
Member

vcunat commented May 29, 2023

Though if it's wrong, we can't easily avoid such a rebuild. Maybe downgrading on aarch64 only (for now?), but that doesn't seem worth it to me.

@wegank
Copy link
Member Author

wegank commented May 29, 2023

I'm going to do a system rebuild to check if aarch64-linux UEFI installations still boot on staging-next. The bug suggests that this is not the case.

@vcunat
Copy link
Member

vcunat commented May 29, 2023

Some installer tests passed on aarch64, but I don't know if they would get broken, off the top of my head: https://hydra.nixos.org/eval/1795672#tabs-still-succeed

@wegank
Copy link
Member Author

wegank commented May 29, 2023

I'm going to do a system rebuild to check if aarch64-linux UEFI installations still boot on staging-next. The bug suggests that this is not the case.

Still boots on my machine, so I guess the revert shouldn't be necessary...

@arianvp
Copy link
Member

arianvp commented Jun 2, 2023

My machine (aarch64 on MacOS Virtualisation.framework) got completely bricked today (EFI doesn't even load system-boot anymore). I have a feeling it might be this version bump that caused it.

@wegank
Copy link
Member Author

wegank commented Jun 2, 2023

Very likely. I guess I'm not able to reproduce the issue as I'm on a different setup (aarch64-darwin, Parallels Desktop).

@vcunat What do you think?

@arianvp
Copy link
Member

arianvp commented Jun 2, 2023

Yes. can confirm that reverting #233944 fixes my machine. I suggest we reopen this PR and merge it into the next staging-next cycle :)

vcunat added a commit that referenced this pull request Jun 2, 2023
@vcunat
Copy link
Member

vcunat commented Jun 2, 2023

OK, done now as cc3ee6d
The cycle was just beginning, so we're hardly lose any work.

@vcunat
Copy link
Member

vcunat commented Jun 2, 2023

r-ryantm will probably open a new PR soon, but we can then comment and draft it.

colemickens pushed a commit to colemickens/nixpkgs that referenced this pull request Jun 5, 2023
colemickens pushed a commit to colemickens/nixpkgs that referenced this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants