Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sound-of-sorting: 0.6.5 -> 20150721 #23549

Merged
merged 2 commits into from
Mar 6, 2017
Merged

sound-of-sorting: 0.6.5 -> 20150721 #23549

merged 2 commits into from
Mar 6, 2017

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Mar 6, 2017

Motivation for this change

Update to git - the stable version doesn't compile
Fixes ZHF #23253

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@AndersonTorres
Copy link
Member Author

A newbie question: I have used the date in a collapsed "yyyymmdd" form as the version attribute. Is it OK?

@Mic92
Copy link
Member

Mic92 commented Mar 6, 2017

@AndersonTorres I changed this to the correct format we use for unstable packages

@Mic92 Mic92 merged commit e96a2f8 into NixOS:master Mar 6, 2017
Mic92 pushed a commit that referenced this pull request Mar 6, 2017
* sound-of-sorting: 0.6.5 -> 20150721

* sound-of-sorting: correct unstable version format

(cherry picked from commit e96a2f8)
@AndersonTorres AndersonTorres deleted the soundOfSorting branch March 7, 2017 01:55
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
* sound-of-sorting: 0.6.5 -> 20150721

* sound-of-sorting: correct unstable version format

(cherry picked from commit e96a2f8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants