networking/bonds: fix examples #23555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Profpatsch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington, @edolstra and @aszlig to be potential reviewers. |
3 tasks
fpletz
approved these changes
Mar 7, 2017
fpletz
added
6.topic: nixos
9.needs: port to stable
|
@fpletz, how would one port to stable? |
|
Could you change |
After the change of the bonding options, the examples were not quite correct. The diff is over-the top because the new `let` needs everything indented. Also add a small docstring to the `networkd` attr in the networking test.
|
done |
grahamc
approved these changes
Mar 7, 2017
|
I suspect @fpletz only meant backport to 17.03, but I'm not sure. |
|
The bonding options weren't backported to 16.09 IIRC, so only 17.03. @Profpatsch You can just |
samueldr
removed
the
9.needs: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the change of the bonding options, the examples were not quite correct.
The diff is over-the top because the new
letneeds everything indented.Also add a small docstring to the
networkdattr in the networking test.