Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintainers: fix formatting/indentation, cleanup #235923

Merged
merged 5 commits into from
Jun 4, 2023

Conversation

emilylange
Copy link
Member

Description of changes

Very quick and easy patch that fixes the formatting and indentation of maintainers.nix, making it somewhat uniform again :)

Things done

No-op, but ran both nix-instantiate --eval maintainers/scripts/check-maintainers-sorted.nix and nix-build lib/tests/maintainers.nix for good measure.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

as this script would otherwise create a bunch of somewhat unnecessary/noisy renames that aren't "actual" renames
as their GitHub account appears to be deleted
as their GitHub account appears to be deleted
@emilylange
Copy link
Member Author

@ajs124 suggested I should run maintainers/scripts/fix-maintainers.pl while I am at it :)

Raw output of that script (but I prefixed the usernames with @ so GitHub tries to look them up and to ping them)

@ilya-kolpakov is now known on github as @1pakch. Editing maintainer-list.nix…
@gordiasdot likely deleted their github account
@jayeshbhoot is now known on github as @bhootjb. Editing maintainer-list.nix…
@citadelcore is now known on github as @VertexA115. Editing maintainer-list.nix…
@uningan is now known on github as @oneingan. Editing maintainer-list.nix…
@WeebSorceress likely deleted their github account
@Fuzen-py is now known on github as @LovingMelody. Editing maintainer-list.nix…

@gordiasdot is a ghost now (#148674)
@WeebSorceress is a ghost as well (#176421)

@emilylange emilylange marked this pull request as ready for review June 4, 2023 14:35
@emilylange emilylange changed the title maintainers: fix formatting/indentation maintainers: fix formatting/indentation, cleanup Jun 4, 2023
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@drupol drupol merged commit a807192 into NixOS:master Jun 4, 2023
18 checks passed
@emilylange emilylange deleted the maintainers-fmt branch June 4, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants