Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim-full: remove redundant nix support patches #236315

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Conversation

ncfavier
Copy link
Member

@ncfavier ncfavier commented Jun 6, 2023

Vim 9 includes syntax highlighting for nix files, but not the ftplugin/indent parts of vim-nix so we still include those.

LnL7/vim-nix#47
vim/vim#11646

cc @LnL7 @jsoo1 @equill

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@jsoo1
Copy link
Contributor

jsoo1 commented Jun 6, 2023

Thank you! Lgtm!

@ofborg ofborg bot requested review from equirosa and dasJ June 6, 2023 18:37
@ncfavier ncfavier changed the title vim_configurable: remove redundant nix support patches vim-full: remove redundant nix support patches Jun 6, 2023
Vim 9 includes syntax highlighting for nix files, but not the
ftplugin/indent parts of vim-nix so we still include those.

LnL7/vim-nix#47
vim/vim#11646
Reflects the name change from `vim_configurable` to `vim-full`.
@ncfavier ncfavier merged commit be57a3d into NixOS:master Jun 7, 2023
21 checks passed
@ncfavier ncfavier deleted the vim-nix branch June 7, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants