Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirtualBox: 5.1.14 -> 5.1.16 #23687

Closed
wants to merge 1 commit into from
Closed

VirtualBox: 5.1.14 -> 5.1.16 #23687

wants to merge 1 commit into from

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Mar 10, 2017

Motivation for this change

Update minor version and other things

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@AndersonTorres, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bbenoist, @edolstra and @aszlig to be potential reviewers.

@bachp
Copy link
Member

bachp commented Mar 11, 2017

I just noticed that this PR is already here and does the same as mine #23716.
The only thing missing here is the update of the extpack. If you could update the checksum there too I will close my PR.

@@ -20,8 +20,8 @@ let

extpack = "baddb7cc49224ecc1147f82d77fce2685ac39941ac9b0aac83c270dd6570ea85";
extpackRev = 112924;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update these too:

extpack = "02f73xxx8vk7g2ym26h6x9id088kff1256y9jbhmn0dz2qb72f58";
extpackRev = 113841;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Many thanks!

@AndersonTorres
Copy link
Member Author

P.S.: I have filled an issue about it - you can read at #23785 .

Update source version, extension pack (Thanks @batchp!)
and guest additions

Also, add gsettings schemas to load file dialogs
(qt5 runtime dependency)
@bachp
Copy link
Member

bachp commented Mar 18, 2017

Virtualbox 5.1.18 is available in the meantime. It fixes some regressions in 5.1.16.

@globin
Copy link
Member

globin commented Mar 20, 2017

I hadn't seen this when updating (07252dc)

Sorry!

@globin globin closed this Mar 20, 2017
@AndersonTorres AndersonTorres deleted the vbox branch March 21, 2017 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants