clementine: added switches for optional dependences

[xvapx]

Added switches for ipod, mtp, cd and cloud support.
The switch for ipod support, specifically, allows users to build it without libplist, wich is marked as insecure.

Motivation for this change

issue #23696

Things done

• Tested using sandboxing
  (nix.useSandbox on NixOS,
  or option build-use-sandbox in nix.conf
  on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • Linux
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

---

I have actually Tested using sandboxing and using nix-shell -p clementine --run "clementine-review wip", but these methods seem to ignore nixpkgs.config.clementine.ipod = false; in my configuration.nix, so i get the same result i got before my changes, an error stating that libplist-1.12 is marked as insecure.

[mention-bot]

@xvapx, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jraygauthier, @bjornfor and @joachifm to be potential reviewers.

[bendlas]

Good approach, I'd like to reinstall clementine. Trying it out ...
BTW, have you tried setting the config into your ~/.nixpkgs/config.nix?

[bendlas]

EDIT with your patch + clementine.ipod = false;, I can run clementine again, thanks!

Could you set the default for clementine.ipod to false? Since that's what's breaking the build, currently.

[xvapx]

No problem, i didn't know if it was better to maintain the defaults to current values, i'll change it.
Thanks to you!

EDIT: sorry, i didn't even know about ~/.nixpkgs/config.nix, i'll test it.

[xvapx]

I tested it again with clementine.ipod = false; in ~/.nixpkgs/config.nix, and sandboxig works as expected, but nix-shell -p clementine --run "clementine-review wip" still complains about libplist-1.12, even with false as the default value.
I wonder if i'm doing something wrong there.
Also, the build is still not working, and i have no idea why.

[bendlas]

That's because nix-shell -p clementine tries to shell into the clementine package, which still comes from your system profile.

You probably wanted nix-shell -p nox ... to shell into the nox package, where you can run e.g. nox-review wip in a nixpkgs checkout, to audit uncommited changes.

[xvapx]

Lol thanks, i completely misunderstood it. i'm going to read about it and try it, thanks!

EDIT: done, it works perfectly, checked against master.