Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

litex: init at 2023.04 #237658

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

litex: init at 2023.04 #237658

wants to merge 6 commits into from

Conversation

RaitoBezarius
Copy link
Member

Description of changes

LiteX is a set of tools to work with FPGAs, I package the bare minimum to compile a VexRISCV for iCEBreaker iCE40 FPGA board.

This was tested with:

$ nix-shell -p 'python3.withPackages (ps: [ ps.litex-boards ps.litex ps.litespi ps.pythondata-cpu-vexriscv ps.pythondata-software-picolibc ps.pythondata-software-compiler_rt ])' 'pkgsCross.riscv32.buildPackages.gcc' 'meson' 'ninja' yosys nextpnr icestorm
$ python3 -m litex_boards.targets.icebreaker --cpu-type=vexriscv --cpu-variant=lite --build

producing a final Gateware for the iCEBreaker which was not tested on the hardware yet :).

TODO : I disabled tests everywhere because for some reason, it's complaining about migen not being there, etc. I am debugging this and this will be fixed or commented properly before merge.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-summer-of-nix-program-goals/30376/3

Comment on lines +6246 to +6248
pythondata-cpu-vexriscv = callPackage ../development/python-modules/pythondata-cpu-vexriscv { };
pythondata-software-picolibc = callPackage ../development/python-modules/pythondata-software-picolibc { };
pythondata-software-compiler_rt = callPackage ../development/python-modules/pythondata-software-compiler_rt { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pythondata-cpu-vexriscv = callPackage ../development/python-modules/pythondata-cpu-vexriscv { };
pythondata-software-picolibc = callPackage ../development/python-modules/pythondata-software-picolibc { };
pythondata-software-compiler_rt = callPackage ../development/python-modules/pythondata-software-compiler_rt { };
pythondata-cpu-vexriscv = callPackage ../development/python-modules/pythondata-cpu-vexriscv { };
pythondata-software-picolibc = callPackage ../development/python-modules/pythondata-software-picolibc { };
pythondata-software-compiler-rt = callPackage ../development/python-modules/pythondata-software-compiler-rt { };

Per python ecosystem docs we always normalise attrs and pnames and replace special characters like underscore with a dash and make it all lower cased.

meta = with lib; {
description = "Python module containing data files for compiler_rt software (for use with LiteX";
homepage = "https://github.com/litex-hub/pythondata-software-compiler_rt";
license = with licenses; [ ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
license = with licenses; [ ];
license = licenses.asl20;

see https://github.com/litex-hub/pythondata-software-compiler_rt/blob/master/LICENSE

@RaitoBezarius
Copy link
Member Author

@SuperSandro2000 FYI, this PR is not for review and you are reviewing code that will completely change.

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants