-
-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kmod: 23 -> 24 and update kmod-blacklist-ubuntu to zesty #23890
Conversation
@peterhoeg, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat, @edolstra and @abbradar to be potential reviewers. |
I would also vote for a backport of the blacklist. The list is supposed to be in sync with the kernel. |
Updating the kmod blacklist broke our X tests (bisected). Good test case:
(then the service will restart a few times and later the test will wait for a timeout.) Any ideas why this happens? Note that we've picked this problem into 17.03 as well /cc @globin. |
The correct log opens |
If nobody has a solution until tomorrow evening, I'll revert on the release branch |
This reverts commit 0c262a6. It broke X tests, though it's not clear why ATM. Discussion: #23890 (comment)
I decided to revert the commit on master immediately, because no rebuilds are caused and nixos-unstable channel is over two weeks old now. We can easily re-revert later. |
Re-reverted in 785e45a with a fix |
Hmm, I've completely forgotten 9f7d7ad. |
Motivation for this change
I've tried building them and they all build fine. I haven't done nox-review wip as it causes quite a bit of rebuilding.
@globin, would you consider this for 17.03 or is it too late?
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)