-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fortran-fpm: init at 0.9.0 #239035
fortran-fpm: init at 0.9.0 #239035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nitpicks, quite a good pr for your first time ❤️
Result of 1 package built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; I will give it a few more days and if no one complains merge it.
Ah i missed your third commit 🙈 can you squash the |
@Janik-Haag Whoops, I figured everything would be squash-merged so I left it alone, but it's all set now. |
No problem, I just checked the diff when approving and reviewed the entire PR before merging and that's when I noticed it ^^ |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-09-11-documentation-team-meeting-notes-79/32917/1 |
Description of changes
fpm
is the package manager and build system for Fortran.https://fpm.fortran-lang.org
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)