Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fortran-fpm: init at 0.9.0 #239035

Merged
merged 2 commits into from
Jun 28, 2023
Merged

fortran-fpm: init at 0.9.0 #239035

merged 2 commits into from
Jun 28, 2023

Conversation

proofconstruction
Copy link
Contributor

@proofconstruction proofconstruction commented Jun 21, 2023

Description of changes

fpm is the package manager and build system for Fortran.

https://fpm.fortran-lang.org

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Member

@Janik-Haag Janik-Haag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nitpicks, quite a good pr for your first time ❤️

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/tools/package-management/fortran-fpm/default.nix Outdated Show resolved Hide resolved
pkgs/tools/package-management/fortran-fpm/default.nix Outdated Show resolved Hide resolved
pkgs/tools/package-management/fortran-fpm/default.nix Outdated Show resolved Hide resolved
pkgs/tools/package-management/fortran-fpm/default.nix Outdated Show resolved Hide resolved
pkgs/tools/package-management/fortran-fpm/default.nix Outdated Show resolved Hide resolved
@Janik-Haag
Copy link
Member

Result of nixpkgs-review pr 239035 run on x86_64-linux 1

1 package built:
  • fortran-fpm

Copy link
Member

@Janik-Haag Janik-Haag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I will give it a few more days and if no one complains merge it.

@Janik-Haag
Copy link
Member

Ah i missed your third commit 🙈 can you squash the fix rec commit into the init commit? I will merge this once you have done that.

@proofconstruction
Copy link
Contributor Author

@Janik-Haag Whoops, I figured everything would be squash-merged so I left it alone, but it's all set now.

@Janik-Haag
Copy link
Member

Janik-Haag commented Jun 28, 2023

No problem, I just checked the diff when approving and reviewed the entire PR before merging and that's when I noticed it ^^
Just waiting for ci now :D

@Janik-Haag Janik-Haag merged commit 93f1e99 into NixOS:master Jun 28, 2023
22 checks passed
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-09-11-documentation-team-meeting-notes-79/32917/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants