Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qtbase: fix patches #24036

Closed
wants to merge 1 commit into from
Closed

qtbase: fix patches #24036

wants to merge 1 commit into from

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Mar 19, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@orivej, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zimbatm, @edolstra and @nbp to be potential reviewers.

@orivej
Copy link
Contributor Author

orivej commented Mar 19, 2017

This also fixes readPathsFromFile after #23851

@orivej orivej mentioned this pull request Mar 19, 2017
7 tasks
peterhoeg pushed a commit to peterhoeg/nixpkgs that referenced this pull request Mar 19, 2017
Generalized from NixOS#24036, and leaving the authorship there.
@vcunat
Copy link
Member

vcunat commented Mar 19, 2017

I fixed the problem in a slightly different way before seeing this PR. Now I generalized the list nitpick under your name.

@vcunat vcunat closed this Mar 19, 2017
@vcunat
Copy link
Member

vcunat commented Mar 19, 2017

Thanks!

@orivej orivej deleted the fix-qtbase-patches branch March 19, 2017 10:17
@orivej
Copy link
Contributor Author

orivej commented Mar 19, 2017

Thank you, I did not know that nested lists were allowed. Yet you should have applied my change to readPathsFromFile as well, since builtins.map (lib.removeSuffix "\n") in the current implementation does not make sense.

@vcunat
Copy link
Member

vcunat commented Mar 19, 2017

Right, pushed.

vcunat pushed a commit that referenced this pull request Mar 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants