Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus-php-fpm-exporter: init at 2.2.0 #240394

Merged
merged 3 commits into from Jun 29, 2023

Conversation

gaelreyrol
Copy link
Contributor

@gaelreyrol gaelreyrol commented Jun 28, 2023

Description of changes

This PR adds a new package php-fpm_exporter which uses PHP-FPM status page to request usage and expose it as Prometheus metrics. It includes the new package and the new exporter in services.prometheus.exporters module.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@gaelreyrol
Copy link
Contributor Author

@GrahamcOfBorg build prometheus-php-fpm-exporter

@gaelreyrol
Copy link
Contributor Author

@GrahamcOfBorg test prometheus-exporters.php-fpm

@gaelreyrol gaelreyrol force-pushed the prometheus-php-fpm-exporter-init branch from ef775de to 94620a2 Compare June 28, 2023 20:10
@gaelreyrol gaelreyrol force-pushed the prometheus-php-fpm-exporter-init branch from 94620a2 to cba0a20 Compare June 28, 2023 20:11
@gaelreyrol gaelreyrol requested a review from drupol June 28, 2023 20:12
@gaelreyrol
Copy link
Contributor Author

@GrahamcOfBorg build prometheus-php-fpm-exporter
@GrahamcOfBorg test prometheus-exporters.php-fpm

@drupol drupol merged commit 958fb96 into NixOS:master Jun 29, 2023
30 checks passed
@gaelreyrol gaelreyrol deleted the prometheus-php-fpm-exporter-init branch June 29, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants