alacritty: --add-rpath instead of --set-rpath #240773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported by @blucoat in #219213 alacritty's RPATH is missing many of the libraries which it links to, including for example glibc. The problem was diagnosed by @kchibisov as being caused by alacritty's use of `--set-rpath` (which completely replaces the rpath) instead of `--add-rpath` (which adds additional entries to the rpath): #219213 (comment) This commit implements @kchibisov's idea to change `--set-rpath` to `--add-rpath`: #219213 (comment) Closes #219213
ghost
requested review from
|
It looks like we have 537 occurrences of Some of those are part of |
|
Maybe our |
|
Acked-by: Kirill Chibisov contact@kchibisov.com |
trofi
approved these changes
Jun 30, 2023
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
As reported by @blucoat in #219213 alacritty's RPATH is missing many of the libraries which it links to, including for example glibc.
The problem was diagnosed by @kchibisov as being caused by alacritty's use of
--set-rpath(which completely replaces the rpath) instead of--add-rpath(which adds additional entries to the rpath):#219213 (comment)
This commit implements @kchibisov's idea to change
--set-rpathto--add-rpath:#219213 (comment)
Closes #219213
Things done
./result/bin/)