Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubootTeresA64: Init #240827

Closed
wants to merge 1 commit into from
Closed

ubootTeresA64: Init #240827

wants to merge 1 commit into from

Conversation

Kreyren
Copy link
Contributor

@Kreyren Kreyren commented Jul 1, 2023

WARNING: First contribution after long time, please review carefully as it's likely that i've made a mistake somewhere..


This contribution adds uboot package for OLIMEX Teres-A64

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux -- No, requires binfmt then it builds
    • [UNABLE] aarch64-linux -- i don't have an arm device with nix yet (blocked by this)
    • [UNABLE] x86_64-darwin -- I don't own darwin
    • [UNABLE] aarch64-darwin -- I don't own darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • [NO] (Package updates) Added a release notes entry if the change is major or breaking
    • [NO] (Module updates) Added a release notes entry if the change is significant
    • [NO] (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@K900
Copy link
Contributor

K900 commented Jul 1, 2023

Also please note the channel PR note. This should go to master, and then be backported to stable branches from there.

@Kreyren
Copy link
Contributor Author

Kreyren commented Jul 1, 2023

The derivation builds and was tested on the device, but lacks crust (power management) as tracked in #240846 as i wasn't able to figure out how to get the OpenRISC compiler, but it doesn't affects the use of Nix just makes sleep and hibernation unreliable and annoying.

Copy link
Contributor

@K900 K900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kreyren Kreyren changed the title uboot: Declaration for OLIMEX Teres-A64 ubootTeresA64: Init Jul 1, 2023
@Kreyren
Copy link
Contributor Author

Kreyren commented Jul 1, 2023

Additional wiki page has been added https://nixos.wiki/wiki/NixOS_on_ARM/OLIMEX_Teres-A64

@Kreyren
Copy link
Contributor Author

Kreyren commented Jul 1, 2023

Seems that noise in my eMMC from armbian made it seem like the contribution works, but it doesn't, Investigating now..

Updates:

  • [02/07/2023 - 02:36:40] The contribution builds and installs without an issue, but the device doesn't have working display (confirmed via serial console)
  • [02/07/2023 - 03:05:49] Confirmed that the display works and is connected to the PCB
  • [02/07/2023 - 03:05:49] The NixOS 23.05 channel is using kernel with broken mesa, see https://www.armbian.com/olimex-teres-a64 for details

Conclusion: Known issue with broken kernel, concluded that it's a userland issue that doesn't affect this contribution.

If possible the build should fail if attempted to build on Linux 6.1.X

@Kreyren Kreyren marked this pull request as draft July 1, 2023 19:50
@Kreyren Kreyren marked this pull request as ready for review July 2, 2023 01:35
@Kreyren Kreyren marked this pull request as draft July 3, 2023 21:11
@Kreyren
Copy link
Contributor Author

Kreyren commented Jul 3, 2023

Obsolete by #241360

@Kreyren Kreyren closed this Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants