Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lumina: fix kwindowsystem and oxygen-icons5 attributes #24101

Merged
merged 1 commit into from
Mar 20, 2017
Merged

lumina: fix kwindowsystem and oxygen-icons5 attributes #24101

merged 1 commit into from
Mar 20, 2017

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Mar 20, 2017

Motivation for this change

The attributes qt5.kwindowsystem and qt5.oxygen-icons5 are not found after the Qt and KDE related packages have been reorganized. See #23180 and #23239.

/cc @ttuegel

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@romildo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ttuegel to be a potential reviewer.

@ttuegel ttuegel merged commit 4837aba into NixOS:master Mar 20, 2017
@romildo romildo deleted the fix.lumina branch March 20, 2017 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants