lambda-lisp: init at 2022-08-18 #242101
Merged
lambda-lisp: init at 2022-08-18 #242101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cafkafk
force-pushed
the
cafkafkdev-lambda-lisp-blc
branch
from
cb28997
to
5150e35
Compare
Artturin
reviewed
Oct 5, 2023
Artturin
reviewed
Oct 5, 2023
Artturin
reviewed
Oct 5, 2023
cafkafk
force-pushed
the
cafkafkdev-lambda-lisp-blc
branch
2 times, most recently
from
c693869
to
efcd11b
Compare
Artturin
reviewed
Oct 5, 2023
Artturin
reviewed
Oct 5, 2023
cafkafk
force-pushed
the
cafkafkdev-lambda-lisp-blc
branch
from
efcd11b
to
3a33038
Compare
Artturin
reviewed
Oct 5, 2023
cafkafk
force-pushed
the
cafkafkdev-lambda-lisp-blc
branch
3 times, most recently
from
1bac7aa
to
1d47a44
Compare
Artturin
reviewed
Oct 5, 2023
cafkafk
force-pushed
the
cafkafkdev-lambda-lisp-blc
branch
7 times, most recently
from
8448441
to
14317ea
Compare
Artturin
reviewed
Oct 5, 2023
| install -D -t $out/bin lambda-lisp-blc | ||
| runHook postInstall | ||
| ''; | ||
|
|
There was a problem hiding this comment.
Is it possible to add some simple tests to installCheckPhase?
There was a problem hiding this comment.
I added one that covers a few arithmetic operations https://github.com/NixOS/nixpkgs/compare/14317ea8bc1b3b97fac3e577852706cf23da6f02..52bdc84582b499de50f4f4af2035d9eb9bc5ba61
This adds lambda lisp, and the lambda-lisp-blc backend. Signed-off-by: Christina Sørensen <christina@cafkafk.com>
cafkafk
force-pushed
the
cafkafkdev-lambda-lisp-blc
branch
from
14317ea
to
52bdc84
Compare
Artturin
reviewed
Oct 5, 2023
| hash = "sha256-qt7vDtn9WvDoBaLESCyyscA0u74914e8ZKhLiUAN52A="; | ||
| }; | ||
|
|
||
| flatSrc = fetchurl { |
There was a problem hiding this comment.
Please make a issue upstream asking them to vendor the files from lambda/ or checking for their existence before wget, that way the makefile targets(ex: interpreters) could be used.
Or email justine to ask for the files to be put in a repo
Artturin
reviewed
Oct 17, 2023
|
|
||
| let | ||
| stdenv = gccStdenv; | ||
| s = import ./sources.nix { inherit fetchurl fetchFromGitHub; }; |
There was a problem hiding this comment.
Mic92/nix-update#202 would make updating the fetchFromGitHub sources faster to update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This adds lambda-lisp, and the lambda-lisp-blc backend. Lambda lisp has several backends, this only adds the blc backend for now, as I'm unsure what the best practice is for adding multiple backends for a package like this.
I added a sources file, which is a structure copied from the djgpp package. Ideally, there would be a lambda-lisp-blc, lambda-lisp-lazyk etc., this sets the package up for that. Also, currently, a user installing lambda-lisp will get lambda-lisp-blc, which should be the best choice, as it is the default backend.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)