Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpExtensions: prevent buildPecl to always use the same version of PHP #242655

Merged
merged 2 commits into from
Jul 10, 2023
Merged

phpExtensions: prevent buildPecl to always use the same version of PHP #242655

merged 2 commits into from
Jul 10, 2023

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Jul 10, 2023 •
edited
Loading

This PR:

Is a follow up of #242366 and #242166

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@drupol drupol force-pushed the php/extensions/mongodb-followup-fix-buildPecl branch 2 times, most recently from 8291067 to f7aa02c Compare July 10, 2023 14:53
@drupol drupol force-pushed the php/extensions/mongodb-followup-fix-buildPecl branch from f7aa02c to 020b80b Compare July 10, 2023 15:06
@drupol
Copy link
Contributor Author

drupol commented Jul 10, 2023

@GrahamcOfBorg build php81Extensions.mongodb php81Extensions.datadog_trace

@2xsaiko
Copy link
Contributor

2xsaiko commented Jul 10, 2023 •
edited
Loading

php81Extensions.mongodb php81Extensions.datadog_trace

These build successfully on my aarch64-darwin machine. (couldn't do nixpkgs-review because of #242680)

log

@drupol drupol merged commit 8ef66bf into master Jul 10, 2023
20 of 21 checks passed
@drupol drupol deleted the php/extensions/mongodb-followup-fix-buildPecl branch July 10, 2023 17:23
This was referenced Jul 10, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wegank wegank wegank left review comments

@jtojnar jtojnar Awaiting requested review from jtojnar jtojnar is a code owner

@aanderse aanderse Awaiting requested review from aanderse aanderse is a code owner

@etu etu Awaiting requested review from etu

@globin globin Awaiting requested review from globin globin is a code owner

@Ma27 Ma27 Awaiting requested review from Ma27 Ma27 is a code owner

@talyz talyz Awaiting requested review from talyz talyz is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drupol @2xsaiko @wegank