Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sox: added enableLibpulseaudio option #24292

Merged
merged 1 commit into from
Mar 24, 2017
Merged

Conversation

elitak
Copy link
Contributor

@elitak elitak commented Mar 24, 2017

Motivation for this change

Added libpulseaudio features to build so pulse sources can be used at runtime.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@elitak, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @taku0 and @MarcWeber to be potential reviewers.

@elitak elitak changed the title sox: added enabelLibpulseaudio option sox: added enableLibpulseaudio option Mar 24, 2017
@7c6f434c 7c6f434c merged commit 201f3ef into NixOS:master Mar 24, 2017
@MarcWeber
Copy link
Contributor

most other packages (eg mplayer) call it pulseSupport. Maybe consistent naming makes sense.

@elitak
Copy link
Contributor Author

elitak commented Mar 24, 2017

All the names in here are a bit nonstandard; I was just trying to maintain file-level consistency. I agree they should be renamed. This PR is merged now though, so I suggest just creating a new PR to change them all, if you're so inclined.

@MarcWeber
Copy link
Contributor

You're right. Just wondering whether it makes sense to introduce a global config.pulseSupport option which can be used by all packages -> then I was told that pulse is going to work with mplayer even without pulse support and that using flags would mean having binary cache misses. Imean there are many packages which can be compiled with gkt/qt (gentoo useflag like). The question is does it make sense to introduce/document such. -> will ask on mailinglist.

@elitak elitak deleted the pulse-sox branch April 10, 2017 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants