Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixpkgs/NixOS manuals: devmode feature #243062

Merged
merged 3 commits into from Jul 27, 2023

Conversation

mightyiam
Copy link
Member

This does not add anything to the NixOS manual intentionally.
I intend to tackle that in #241871.

Co-authored-by: Alejandro Sanchez Medina alejandrosanchzmedina@gmail.com

doc/default.nix Outdated Show resolved Hide resolved
doc/contributing/contributing-to-documentation.chapter.md Outdated Show resolved Hide resolved
doc/contributing/contributing-to-documentation.chapter.md Outdated Show resolved Hide resolved
doc/default.nix Outdated Show resolved Hide resolved
doc/default.nix Outdated Show resolved Hide resolved
doc/default.nix Outdated Show resolved Hide resolved
pkgs/tools/nix/web-devmode.nix Outdated Show resolved Hide resolved
pkgs/tools/nix/web-devmode.nix Outdated Show resolved Hide resolved
pkgs/tools/nix/web-devmode.nix Outdated Show resolved Hide resolved
pkgs/tools/nix/web-devmode.nix Outdated Show resolved Hide resolved
pkgs/tools/nix/web-devmode.nix Outdated Show resolved Hide resolved
pkgs/tools/nix/web-devmode.nix Outdated Show resolved Hide resolved
pkgs/tools/nix/web-devmode.nix Outdated Show resolved Hide resolved
pkgs/tools/nix/web-devmode.nix Outdated Show resolved Hide resolved
pkgs/tools/nix/web-devmode.nix Outdated Show resolved Hide resolved
pkgs/tools/nix/web-devmode.nix Outdated Show resolved Hide resolved
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-07-13-documentation-team-meeting-notes-63/30450/1

Copy link
Contributor

@pennae pennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is getting somewhere :) mostly nitpicks left now, overall it's looking pretty good.

pkgs/tools/nix/web-devmode.nix Outdated Show resolved Hide resolved
pkgs/tools/nix/web-devmode.nix Show resolved Hide resolved
pkgs/tools/nix/web-devmode.nix Outdated Show resolved Hide resolved
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-07-20-documentation-team-meeting-notes-65/30876/1

@mightyiam
Copy link
Member Author

:shipit: ?

alejandrosame and others added 3 commits July 25, 2023 17:00
Co-authored-by: Shahar "Dawn" Or <mightyiampresence@gmail.com>
Co-authored-by: Shahar "Dawn" Or <mightyiampresence@gmail.com>
Co-authored-by: Alejandro Sanchez Medina <alejandrosanchzmedina@gmail.com>
Copy link
Contributor

@pennae pennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's still a corner case of the live server getting a bit stuck when you rename the output file you're currently viewing, in that case it'll just show a "could not GET" message and won't reload anything. but that's almost certainly a live-server issue, so we'd call this good now.

@infinisil infinisil merged commit a7e5800 into NixOS:master Jul 27, 2023
19 checks passed
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-07-27-documentation-team-meeting-notes-67/30998/1

@mightyiam mightyiam deleted the doc_watchexec branch July 27, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants