Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

citrix-receiver: fix wrapper, direct dl url, $PWD needs escaping #24320

Closed
wants to merge 1 commit into from
Closed

citrix-receiver: fix wrapper, direct dl url, $PWD needs escaping #24320

wants to merge 1 commit into from

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Mar 25, 2017 •
edited

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@veprbl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @obadz and @aske to be potential reviewers.

@veprbl veprbl changed the title citrix-receiver: fix wrapper, direct dl url, /home/demo/nixpkgs needs… citrix-receiver: fix wrapper, direct dl url, $PWD needs escaping Mar 25, 2017
@veprbl
Copy link
Member Author

veprbl commented Mar 25, 2017 •
edited

The problem with $PWD is that it gets expanded before time and prints an unusable path in /tmp/ . I guess the reason for including this was to help users with file:// URI schema limitations, but I don't think that is really necessary. I can replace it with \$PWD, if you request, though.

obadz pushed a commit that referenced this pull request Mar 26, 2017
@veprbl @obadz
citrix-receiver: fix wrapper, direct dl url, $PWD needs escaping
8c6e917 
(edited by @obadz, closes #24320)

(cherry picked from commit 7035325)
@obadz obadz closed this in 7035325 Mar 26, 2017
@veprbl
Copy link
Member Author

veprbl commented Mar 26, 2017

Thank you!

@obadz
Copy link
Contributor

obadz commented Mar 26, 2017

np, thanks for the PR!

@veprbl veprbl deleted the cf branch May 14, 2017 04:31
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
@adrianpk
citrix-receiver: fix wrapper, direct dl url, $PWD needs escaping
db17a75 
(edited by @obadz, closes NixOS#24320)

(cherry picked from commit 7035325)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @mention-bot @obadz