postgresqlPackages.pg_embedding: init at 0.3.1 #243216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No minimum PostgreSQL version is documented, but it fails to build with PostgreSQL 13: ``` embedding.c:543:18: error: 'IndexAmRoutine' has no member named 'amadjustmembers' 543 | amroutine->amadjustmembers = NULL; ```
ivan
changed the title
vrmiguel
reviewed
Aug 2, 2023
| homepage = "https://github.com/neondatabase/pg_embedding"; | ||
| maintainers = with maintainers; [ ivan ]; | ||
| platforms = postgresql.meta.platforms; | ||
| license = licenses.postgresql; |
There was a problem hiding this comment.
It doesn't seem like pg_embedding is still PostgreSQL-licensed.
The LICENSE file has been removed
|
Replaced with #257164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This adds https://github.com/neondatabase/pg_embedding to nixpkgs. See also https://neon.tech/blog/pg-embedding-extension-for-vector-search
No minimum PostgreSQL version is documented, but it fails to build with PostgreSQL 13:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)I tested that the basic querying documented in https://github.com/neondatabase/pg_embedding#usage-summary works on PostgreSQL 15.3 on x86_64 NixOS 23.05.