Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nftables service: Adds a heads-up regarding nftables and Docker incompability #24326

Merged
merged 1 commit into from
Mar 25, 2017

Conversation

rzetterberg
Copy link
Member

Motivation for this change

It took a while for me to figure out that Docker uses iptables internally and that I had to disable it manually for nftables to work.

To try to mitigate the problem of "tribal knowledge" I added a heads-up in the description of the networking.nftables.enable attribute.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@rzetterberg, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Jookia and @Mic92 to be potential reviewers.

@globin globin merged commit dc10688 into NixOS:master Mar 25, 2017
globin pushed a commit that referenced this pull request Mar 25, 2017
There are other programs that use iptables internally too, such as
libvirt.

[1]: https://github.com/NixOS/nixpkgs/issues/24318#issuecomment-289216273
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a set of tools compatible with nftables: http://git.netfilter.org/iptables/ which could be a drop-in replacement.
However I personally just disabled docker's firewalling at the moment:

virtualisation.docker.extraOptions = "--iptables=false";

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Yeah, I went with that solution too 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants