Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isabelle: 2022 -> 2023 #243497

Merged
merged 3 commits into from
Dec 10, 2023
Merged

isabelle: 2022 -> 2023 #243497

merged 3 commits into from
Dec 10, 2023

Conversation

jvanbruegge
Copy link
Contributor

@jvanbruegge jvanbruegge commented Jul 14, 2023 •
edited

Description of changes

Changelog file

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@jvanbruegge jvanbruegge changed the title Isabelle 2023 isabelle: 2022 -> 2023-RC1 Jul 14, 2023
@ofborg ofborg bot requested a review from jwiegley July 14, 2023 15:46
@jvanbruegge jvanbruegge changed the title isabelle: 2022 -> 2023-RC1 isabelle: 2022 -> 2023-RC3 Aug 15, 2023
@jvanbruegge jvanbruegge marked this pull request as ready for review September 18, 2023 09:51
@jvanbruegge jvanbruegge changed the title isabelle: 2022 -> 2023-RC3 isabelle: 2022 -> 2023 Sep 18, 2023
@jvanbruegge jvanbruegge mentioned this pull request Sep 18, 2023
Closed
12 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2684

@jvanbruegge jvanbruegge mentioned this pull request Oct 5, 2023
Open
65 tasks
@jvanbruegge
Copy link
Contributor Author

@SuperSandro2000 can this be merged?

@jvanbruegge
Copy link
Contributor Author

In the meantime a release of the linter was tagged, updated the commit accordingly

@lukasstevens
Copy link

Would it make sense to also include the AFP as a component? I defined this derivation for it: https://github.com/lukasstevens/dotfiles/blob/a971a4c0bee283d27351413e1cc47e239812ad17/nix/isabelle/components/afp.nix

@Chaostheorie
Copy link
Contributor

@lukasstevens the AFP doesn't sound like a component that should be included in nixpkgs. It's important but afaik is changing too often and not really something that fits into a software package collection.

@jvanbruegge
Copy link
Contributor Author

@SuperSandro2000 can we merge this now?

@Chaostheorie
Copy link
Contributor

At least the server component of Isabelle 2023 (from this MR) had also been tested on arm64 (rp4).

@jvanbruegge
Copy link
Contributor Author

@SuperSandro2000 sorry for the ping, but this has been sitting for a while now

@wegank
Copy link
Member

wegank commented Dec 10, 2023

@ofborg build tlaps tlaps.passthru.tests

@wegank wegank merged commit 64891e3 into NixOS:master Dec 10, 2023
22 of 26 checks passed
@jvanbruegge
Copy link
Contributor Author

Thanks!

@jvanbruegge jvanbruegge deleted the isabelle-2023 branch December 10, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@jwiegley jwiegley Awaiting requested review from jwiegley

@wegank wegank Awaiting requested review from wegank

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jvanbruegge @nixos-discourse @lukasstevens @Chaostheorie @wegank @SuperSandro2000