Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easyabc: pin wxPython #243787

Merged
merged 1 commit into from
Aug 20, 2023
Merged

easyabc: pin wxPython #243787

merged 1 commit into from
Aug 20, 2023

Conversation

mausch
Copy link
Member

@mausch mausch commented Jul 16, 2023

Description of changes

Closes #243561
Package broken in adf84c3

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@mausch mausch mentioned this pull request Jul 16, 2023
12 tasks
Comment on lines 21 to 30
# currently broken with 4.2.1
# https://github.com/jwdj/EasyABC/issues/75
(wxPython_4_2.overrideAttrs (args: rec {
version = "4.2.0";
src = fetchPypi {
inherit version;
pname = "wxPython";
hash = "sha256-ZjzrxFCdfl0RNRiGX+J093+VQ0xdV7w4btWNZc7thsc=";
};
}))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use a python package set overwrite otherwise we might end up with two different wxpython which will break the build.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry no idea what a "python package set overwrite" is 😕

we might end up with two different wxpython which will break the build.

I don't follow... I do want a different specific version of wxpython here, otherwise easyabc breaks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in d373fd4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow... I do want a different specific version of wxpython here, otherwise easyabc breaks.

some other dependency could also use it and we want to make sure that we only use one wxpython for everything

@dotlambda
Copy link
Member

dotlambda commented Aug 4, 2023

You should use

let
  python = python39.override {
    packageOverrides = self: super: {
      wxPython = ...
    };
  };
in python.buildPythonApplication ...

@mausch mausch force-pushed the easyabc branch 3 times, most recently from e48ee08 to d373fd4 Compare August 5, 2023 16:28
@kirillrdy
Copy link
Member

Result of nixpkgs-review pr 243787 run on x86_64-linux 1

1 package built:
  • easyabc

@dotlambda
Copy link
Member

Result of nixpkgs-review pr 243787 run on x86_64-linux 1

1 package built:
  • easyabc

@dotlambda dotlambda merged commit 87c409e into NixOS:master Aug 20, 2023
20 of 21 checks passed
@mausch mausch deleted the easyabc branch August 21, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants