-
-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
easyabc: pin wxPython #243787
easyabc: pin wxPython #243787
Conversation
# currently broken with 4.2.1 | ||
# https://github.com/jwdj/EasyABC/issues/75 | ||
(wxPython_4_2.overrideAttrs (args: rec { | ||
version = "4.2.0"; | ||
src = fetchPypi { | ||
inherit version; | ||
pname = "wxPython"; | ||
hash = "sha256-ZjzrxFCdfl0RNRiGX+J093+VQ0xdV7w4btWNZc7thsc="; | ||
}; | ||
})) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should use a python package set overwrite otherwise we might end up with two different wxpython which will break the build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry no idea what a "python package set overwrite" is 😕
we might end up with two different wxpython which will break the build.
I don't follow... I do want a different specific version of wxpython here, otherwise easyabc breaks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied in d373fd4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't follow... I do want a different specific version of wxpython here, otherwise easyabc breaks.
some other dependency could also use it and we want to make sure that we only use one wxpython for everything
You should use let
python = python39.override {
packageOverrides = self: super: {
wxPython = ...
};
};
in python.buildPythonApplication ... |
e48ee08
to
d373fd4
Compare
Result of 1 package built:
|
Result of 1 package built:
|
Description of changes
Closes #243561
Package broken in adf84c3
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)