Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scalafmt: 3.7.9 -> 3.7.14 #243915

Closed
wants to merge 1 commit into from
Closed

scalafmt: 3.7.9 -> 3.7.14 #243915

wants to merge 1 commit into from

Conversation

JesusMtnez
Copy link
Contributor

@JesusMtnez JesusMtnez commented Jul 17, 2023 •
edited

Description of changes

https://github.com/scalameta/scalafmt/releases/tag/v3.7.14

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from markus1189 July 17, 2023 06:21
@JesusMtnez JesusMtnez changed the title scalafmt: 3.7.9 -> 3.7.10 scalafmt: 3.7.9 -> 3.7.11 Jul 28, 2023
markus1189
markus1189 approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@markus1189 markus1189 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine

@JesusMtnez JesusMtnez changed the title scalafmt: 3.7.9 -> 3.7.11 scalafmt: 3.7.9 -> 3.7.12 Aug 4, 2023
@ofborg ofborg bot requested a review from markus1189 August 4, 2023 05:32
@JesusMtnez JesusMtnez changed the title scalafmt: 3.7.9 -> 3.7.12 scalafmt: 3.7.9 -> 3.7.14 Sep 5, 2023
@JesusMtnez
Copy link
Contributor Author

@markus1189 could I have your review whenever possible? Thank you!

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2712

@JesusMtnez JesusMtnez closed this Dec 26, 2023
@JesusMtnez JesusMtnez deleted the scalafmt branch December 26, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markus1189 markus1189 markus1189 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JesusMtnez @nixos-discourse @markus1189