Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pop: init at 0.1.0 #243973

Merged
merged 1 commit into from
Jul 25, 2023
Merged

pop: init at 0.1.0 #243973

merged 1 commit into from
Jul 25, 2023

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Jul 17, 2023 •
edited

Description of changes

added new package: pop

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from maaslalani July 17, 2023 13:48
ambroisie
ambroisie requested changes Jul 17, 2023
View reviewed changes
pkgs/applications/misc/pop/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/pop/default.nix Show resolved Hide resolved
@ofborg ofborg bot requested a review from maaslalani July 17, 2023 15:51
ambroisie
ambroisie reviewed Jul 17, 2023
View reviewed changes
Copy link
Contributor

@ambroisie ambroisie left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the commits should be squashed (I hadn't noticed on my first review).

@caarlos0 @maaslalani
pop: init at 0.1.0
d8d7512 
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Co-authored-by: Maas Lalani <maas@lalani.dev>
@caarlos0
Copy link
Member Author

@ambroisie sorry, done!

@maaslalani maaslalani mentioned this pull request Jul 17, 2023
Merged
@maaslalani
Copy link
Contributor

@ambroisie Is this good to merge?

@ambroisie
Copy link
Contributor

It is, but I don't have merge bits.

@siraben siraben merged commit 4aeb502 into NixOS:master Jul 25, 2023
21 checks passed
@caarlos0 caarlos0 deleted the pop branch July 25, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambroisie ambroisie ambroisie approved these changes

@maaslalani maaslalani maaslalani approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@caarlos0 @maaslalani @ambroisie @siraben