Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.maxminddb: fix build on Darwin #244063

Merged
merged 1 commit into from Jul 18, 2023
Merged

python3Packages.maxminddb: fix build on Darwin #244063

merged 1 commit into from Jul 18, 2023

Conversation

reckenrode
Copy link
Contributor

@reckenrode reckenrode commented Jul 17, 2023 •
edited

Description of changes

The multiprocessing tests don’t work on Darwin presumably because it uses the spawn start method instead of fork. Disable those tests to allow maxminddb to build on Darwin again.

Fixes #243998.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@reckenrode
python3Packages.maxminddb: fix build on Darwin
41d5756 
The multiprocessing tests don’t work on Darwin presumably because it
uses the spawn start method instead of fork. Disable those tests to
allow maxminddb to build on Darwin again.
@tjni
Copy link
Contributor

tjni commented Jul 17, 2023

Result of nixpkgs-review pr 244063 run on aarch64-darwin 1

8 packages failed to build:
  • python310Packages.pytest-ansible
  • python310Packages.pytest-ansible.dist
  • python311Packages.pytest-ansible
  • python311Packages.pytest-ansible.dist
  • python311Packages.pytest-testinfra
  • python311Packages.pytest-testinfra.dist
  • python311Packages.sopel
  • python311Packages.sopel.dist
51 packages built:
  • ansible (python310Packages.ansible-core)
  • ansible-later
  • ansible-later.dist
  • ansible-lint
  • ansible-lint.dist
  • ansible.dist (python310Packages.ansible-core.dist)
  • ansible_2_13
  • ansible_2_13.dist
  • ansible_2_14
  • ansible_2_14.dist
  • kargo
  • kargo.dist
  • parsedmarc (python310Packages.parsedmarc)
  • parsedmarc.dist (python310Packages.parsedmarc.dist)
  • python310Packages.ansible
  • python310Packages.ansible-compat
  • python310Packages.ansible-compat.dist
  • python310Packages.ansible-kernel
  • python310Packages.ansible-kernel.dist
  • python310Packages.ansible-runner
  • python310Packages.ansible-runner.dist
  • python310Packages.ansible.dist
  • python310Packages.geoip2
  • python310Packages.geoip2.dist
  • python310Packages.maxminddb
  • python310Packages.maxminddb.dist
  • python310Packages.pytest-testinfra
  • python310Packages.pytest-testinfra.dist
  • python310Packages.sopel
  • python310Packages.sopel.dist
  • ttp (python310Packages.ttp)
  • ttp.dist (python310Packages.ttp.dist)
  • python311Packages.ansible
  • python311Packages.ansible-compat
  • python311Packages.ansible-compat.dist
  • python311Packages.ansible-core
  • python311Packages.ansible-core.dist
  • python311Packages.ansible-kernel
  • python311Packages.ansible-kernel.dist
  • python311Packages.ansible-runner
  • python311Packages.ansible-runner.dist
  • python311Packages.ansible.dist
  • python311Packages.geoip2
  • python311Packages.geoip2.dist
  • python311Packages.maxminddb
  • python311Packages.maxminddb.dist
  • python311Packages.parsedmarc
  • python311Packages.parsedmarc.dist
  • python311Packages.ttp
  • python311Packages.ttp.dist
  • zeronet-conservancy

tjni
tjni approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@tjni tjni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. The failures I saw on my machine look unrelated.

@reckenrode
Copy link
Contributor Author

I also have pytest-ansible failures, which look to be due to trying to connect to localhost and failing.

@reckenrode
Copy link
Contributor Author

reckenrode commented Jul 17, 2023 •
edited

sopel’s tests are failing due to the removal in Python 3.11 of a deprecated mode argument to open.

From What’s New in Python 3.11

open(), io.open(), codecs.open() and fileinput.FileInput no longer accept 'U' (“universal newline”) in the file mode. In Python 3, “universal newline” mode is used by default whenever a file is opened in text mode, and the 'U' flag has been deprecated since Python 3.3. The newline parameter to these functions controls how universal newlines work. (Contributed by Victor Stinner in bpo-37330.)

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 17, 2023
@tjni
Copy link
Contributor

tjni commented Jul 17, 2023

Proposed maxmind/MaxMind-DB-Reader-python#116 to try and fix the tests upstream too in the simplest way so in the future we might be able to clean this up.

@reckenrode
Copy link
Contributor Author

Result of nixpkgs-review pr 244063 run on x86_64-darwin 1

8 packages failed to build:
  • python310Packages.pytest-ansible
  • python310Packages.pytest-ansible.dist
  • python311Packages.pytest-ansible
  • python311Packages.pytest-ansible.dist
  • python311Packages.pytest-testinfra
  • python311Packages.pytest-testinfra.dist
  • python311Packages.sopel
  • python311Packages.sopel.dist
51 packages built:
  • ansible (python310Packages.ansible-core)
  • ansible-later
  • ansible-later.dist
  • ansible-lint
  • ansible-lint.dist
  • ansible.dist (python310Packages.ansible-core.dist)
  • ansible_2_13
  • ansible_2_13.dist
  • ansible_2_14
  • ansible_2_14.dist
  • kargo
  • kargo.dist
  • parsedmarc (python310Packages.parsedmarc)
  • parsedmarc.dist (python310Packages.parsedmarc.dist)
  • python310Packages.ansible
  • python310Packages.ansible-compat
  • python310Packages.ansible-compat.dist
  • python310Packages.ansible-kernel
  • python310Packages.ansible-kernel.dist
  • python310Packages.ansible-runner
  • python310Packages.ansible-runner.dist
  • python310Packages.ansible.dist
  • python310Packages.geoip2
  • python310Packages.geoip2.dist
  • python310Packages.maxminddb
  • python310Packages.maxminddb.dist
  • python310Packages.pytest-testinfra
  • python310Packages.pytest-testinfra.dist
  • python310Packages.sopel
  • python310Packages.sopel.dist
  • ttp (python310Packages.ttp)
  • ttp.dist (python310Packages.ttp.dist)
  • python311Packages.ansible
  • python311Packages.ansible-compat
  • python311Packages.ansible-compat.dist
  • python311Packages.ansible-core
  • python311Packages.ansible-core.dist
  • python311Packages.ansible-kernel
  • python311Packages.ansible-kernel.dist
  • python311Packages.ansible-runner
  • python311Packages.ansible-runner.dist
  • python311Packages.ansible.dist
  • python311Packages.geoip2
  • python311Packages.geoip2.dist
  • python311Packages.maxminddb
  • python311Packages.maxminddb.dist
  • python311Packages.parsedmarc
  • python311Packages.parsedmarc.dist
  • python311Packages.ttp
  • python311Packages.ttp.dist
  • zeronet-conservancy

@wegank
Copy link
Member

wegank commented Jul 18, 2023

@ofborg build python3Packages.maxminddb python3Packages.maxminddb.passthru.tests

@wegank wegank merged commit 897f5b1 into NixOS:master Jul 18, 2023
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjni tjni tjni approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: python3.10-maxminddb-2.4.0
3 participants
@reckenrode @tjni @wegank