Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.trafilatura: init at 1.6.3 #244656

Merged
merged 6 commits into from Feb 7, 2024
Merged

python3Packages.trafilatura: init at 1.6.3 #244656

merged 6 commits into from Feb 7, 2024

Conversation

jokatzke
Copy link
Contributor

@jokatzke jokatzke commented Jul 21, 2023 •
edited

Description of changes

Add trafilatura, a "Python & command-line tool to gather text on the Web".
Also add its unpackaged dependencies (courlan, htmldate, jusText, py3langid).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from fabaff and FRidh July 21, 2023 13:02
fabaff
fabaff reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For adding a new package the commit messages should be as mentioned in https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md and separated by packages.

pkgs/development/python-modules/charset-normalizer/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/courlan/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/courlan/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/courlan/default.nix Show resolved Hide resolved
pkgs/development/python-modules/htmldate/default.nix Show resolved Hide resolved
pkgs/development/python-modules/trafilatura/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/htmldate/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/justext/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/py3langid/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/py3langid/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from fabaff July 25, 2023 14:14
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2585

@fabaff
Copy link
Member

fabaff commented Aug 24, 2023

The commit message for charset-normalizer needs fixing.

@jokatzke
Copy link
Contributor Author

The commit message for charset-normalizer needs fixing.

Ah, sorry about that! I copied the format from one of your pull requests, I hope that fixed it .

@jokatzke jokatzke force-pushed the trafilatura branch 2 times, most recently from f640b7d to ba56806 Compare October 16, 2023 09:16
@jokatzke jokatzke changed the title python3Packages.trafilatura: init at 1.6.1 python3Packages.trafilatura: init at 1.6.2 Oct 18, 2023
@jokatzke
Copy link
Contributor Author

Now that a newer version of charset-normalizer is in the master branch, I removed my update to its version. This significantly reduced the number of affected packages by this pull request :)

@jokatzke jokatzke changed the title python3Packages.trafilatura: init at 1.6.2 python3Packages.trafilatura: init at 1.6.3 Dec 19, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3364

@genevieve-me
Copy link

Seems fine in my testing:

Result of nixpkgs-review pr 244656 run on x86_64-linux 1

20 packages built:
  • python310Packages.courlan
  • python310Packages.courlan.dist
  • python310Packages.htmldate
  • python310Packages.htmldate.dist
  • python310Packages.justext
  • python310Packages.justext.dist
  • python310Packages.py3langid
  • python310Packages.py3langid.dist
  • python310Packages.trafilatura
  • python310Packages.trafilatura.dist
  • python311Packages.courlan
  • python311Packages.courlan.dist
  • python311Packages.htmldate
  • python311Packages.htmldate.dist
  • python311Packages.justext
  • python311Packages.justext.dist
  • python311Packages.py3langid
  • python311Packages.py3langid.dist
  • python311Packages.trafilatura
  • python311Packages.trafilatura.dist

@SuperSandro2000
Copy link
Member

@ofborg build python3Packages.trafilatura

@SuperSandro2000 SuperSandro2000 merged commit bc48aab into NixOS:master Feb 7, 2024
23 of 24 checks passed
@jokatzke jokatzke deleted the trafilatura branch February 8, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@fabaff fabaff Awaiting requested review from fabaff

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jokatzke @nixos-discourse @fabaff @genevieve-me @SuperSandro2000 @Janik-Haag