-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
woodpecker-*: 0.15.11 -> 1.0.0 #246186
woodpecker-*: 0.15.11 -> 1.0.0 #246186
Conversation
I have yet to test this on my infra, but uploading it now so that others can also try it out. EDIT: seems to work. |
I tried using the new |
@tek you need to add it to the service's path (it can't access the system packages as a security measure). See my dotfiles for an example. |
Should we configure the module to add this to the service path by default? |
I think it's best not to bloat the closure of a service if it is not needed. As a middle-ground, I think we might be able to add a EDIT: this can be done in a parallel PR, let's keep this one focused on updating the package. |
oh thanks, I examined the systemd attributes for quite a while and couldn't figure out what the right way to do this was! |
6594d36
to
31b6d45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've upgraded my server and agent to this PR, and verified the CLI.
I'll add myself as maintainer after merge unless you want to add me in this PR.
That's fine with me :-). I think you should be the author of the commit for adding yourself. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1035 |
hey thanks for doing this! |
Description of changes
Closes #246104. Release note here and blog post there.
Since #231513 has not been closed, I've decided to bump
pnpm-lock-export
to a fork which has v6 support, in order to package the front-end.This release includes a lot of breaking changes.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)