Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

woodpecker-*: 0.15.11 -> 1.0.0 #246186

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Conversation

ambroisie
Copy link
Contributor

Description of changes

Closes #246104. Release note here and blog post there.

Since #231513 has not been closed, I've decided to bump pnpm-lock-export to a fork which has v6 support, in order to package the front-end.

This release includes a lot of breaking changes.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • [] Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ambroisie
Copy link
Contributor Author

ambroisie commented Jul 30, 2023

I have yet to test this on my infra, but uploading it now so that others can also try it out.

EDIT: seems to work.

@tek
Copy link
Contributor

tek commented Jul 31, 2023

I tried using the new local backend with this, and it complains that it can't find plugin-git in the PATH, even if it's in systemPackages.

@ambroisie
Copy link
Contributor Author

ambroisie commented Jul 31, 2023

@tek you need to add it to the service's path (it can't access the system packages as a security measure).

See my dotfiles for an example.

@adamcstephens
Copy link
Contributor

I tried using the new local backend with this, and it complains that it can't find plugin-git in the PATH, even if it's in systemPackages.

Should we configure the module to add this to the service path by default?

@ambroisie
Copy link
Contributor Author

ambroisie commented Jul 31, 2023

Should we configure the module to add this to the service path by default?

I think it's best not to bloat the closure of a service if it is not needed. As a middle-ground, I think we might be able to add a path option to the services.woodpecker-agents.agents.<name> attribute set (and make use of it in the example configuration).

EDIT: this can be done in a parallel PR, let's keep this one focused on updating the package.

@tek
Copy link
Contributor

tek commented Jul 31, 2023

@tek you need to add it to the service's path (it can't access the system packages as a security measure).

See my dotfiles for an example.

oh thanks, I examined the systemd attributes for quite a while and couldn't figure out what the right way to do this was!

Copy link
Contributor

@adamcstephens adamcstephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've upgraded my server and agent to this PR, and verified the CLI.

I'll add myself as maintainer after merge unless you want to add me in this PR.

@ambroisie
Copy link
Contributor Author

I'll add myself as maintainer after merge unless you want to add me in this PR.

That's fine with me :-). I think you should be the author of the commit for adding yourself.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1035

@AndersonTorres AndersonTorres merged commit 8bbf6a3 into NixOS:master Aug 1, 2023
21 of 22 checks passed
@pjjw
Copy link
Contributor

pjjw commented Aug 3, 2023

hey thanks for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update request: woodpecker 0.15.11 → 1.0.0
6 participants