nixos/mautrix-whatsapp: init #246842
nixos/mautrix-whatsapp: init #246842
Conversation
Import from PR NixOS#176025 Co-authored-by: Luflosi <Luflosi@users.noreply.github.com>
This contribution applies suggestions made by Luflosi in NixOS#176025 (comment) as well as some general refactoring. Co-authored-by: Luflosi <Luflosi@users.noreply.github.com>
This contribution applies Example 32 (conventional settings option) from [nixpkgs](https://nixos.org/manual/nixos/stable/#sec-settings-nix-representable).
|
@NickCao ping |
As suggested by @NickCao this commit moves the defaults back to the options. Only `homeserver.domain` stays in the config section since the documentation module does not support referencing attributes of other modules.
|
It would have been nice if you had posted a comment in the other PRs so that everyone there would have gotten a notification. The only way I noticed this PR is that I rebuilt my system and the options introduced by this PR collided with the ones that I defined. I think you made a small mistake by defining |
|
I'll create another PR soon™️ to address this and a few other small things I found. Thank you for finally getting this module into NixOS! |
|
Thanks a lot for your work and sorry for my slow replies ! Someone has test https://gitlab.com/coffeetables/nix-matrix-appservices/-/tree/main ? It seems that would be nice to integrate #114419 Have great day |
|
@frederictobiasc I don't see your name in the all-maintainers list. Can you add this in another PR, following these guidelines: https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md |
|
@eclairevoyant Hi and please excuse the delay. Thank you for spotting this. I created a PR: #252615 |
Hi,
there already exists two merge requests regarding init of mautrix-whatsapp:
I don't know what the canonical way of dealing with this situation is, but I would like to get a mautrix-whatsapp module introduced. That's why I did my best to pull together all suggestions from those two pull requests and also update them to be compatible with the current version of mautrix-whatsapp. Major changes were in the log configuration.
I'm currently running this configuration successfully on my server.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)