add mpiCheckPhaseHook #246867
Merged
add mpiCheckPhaseHook #246867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuskowa
force-pushed
the
add-mpi-hook
branch
from
88326c2
to
77f1e58
Compare
|
Did most of a rebuild on macos 10.15, didn't spot any new failures.. |
hmenke
approved these changes
Aug 22, 2023
pkgs/build-support/setup-hooks/mpi-check-hook/mpi-check-hook.sh
Outdated
Show resolved
Hide resolved
Comment on lines
12
to
30
| # OpenMPI signature | ||
| if command ompi_info &> /dev/null; then | ||
| mpiType="openmpi" | ||
| fi | ||
|
|
||
| # MPICH based implementations | ||
| if command mpichversion &> /dev/null; then | ||
| version=$(mpichversion) | ||
| if [[ "$version" == *"MPICH"* ]]; then | ||
| mpiType="MPICH" | ||
| fi | ||
| if [[ "$version" == *"MVAPICH"* ]]; then | ||
| mpiType="MVAPICH" | ||
| fi | ||
| fi |
There was a problem hiding this comment.
In the unlikely event of two MPI implementations being present, this will be ambiguous. Maybe add a warning or error for such a case?
There was a problem hiding this comment.
In the build sandbox this is rather unlikely, but it could happen in a nix-shell.
markuskowa
force-pushed
the
add-mpi-hook
branch
from
77f1e58
to
3cf7b21
Compare
Add this hook to checkPhase to allow for running MPI application in the sandbox. It detects the MPI implementations and sets the respective environment variables.
markuskowa
force-pushed
the
add-mpi-hook
branch
from
3cf7b21
to
cfc44b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
MPI programs usually expect some kind of bare metal machine to run its tasks. Packages that run a test (i.e. in the checkPhase) have to do so in the sandbox.
The new hook sets variables to allow it for running in smoothly in a sandbox.
It avoids the boiler plate of setting these variables for each package.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)