emacs: update to 29.1 #247357
Merged
emacs: update to 29.1 #247357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deejayem can you (or any Mac user) test this? |
ofborg
bot
requested review from
adisbladis,
jwiegley,
lovek323,
Atemu and
matthewbauer
AndersonTorres
force-pushed
the
emacs-update
branch
from
95c57d7
to
f91d69d
Compare
deejayem
approved these changes
Aug 5, 2023
|
Oh, sorry, I tested before the refactoring. With the new version I get this: |
|
Never mind I copy/pasted the wrong PR. Same error as above. |
AndersonTorres
force-pushed
the
emacs-update
branch
from
f91d69d
to
d756ae2
Compare
|
Now we can try again! |
|
@ofborg build emacs-macport |
|
@FlorianFranzen can you please copy-paste the failure on notmuch? |
hraban
reviewed
Aug 5, 2023
AndersonTorres
force-pushed
the
emacs-update
branch
from
d756ae2
to
b4a7b73
Compare
|
aarch64-darwin GNU Emacs 29.1 (build 1, aarch64-apple-darwin22.5.0, NS appkit-2299.60 Version 13.4.1 (c) (Build 22F770820d)) |
|
Result of 28 packages marked as broken and skipped:
9 packages failed to build:
5858 packages built:
|
AndersonTorres
added a commit
to atorres1985-contrib/nixpkgs
that referenced
this pull request
Aug 10, 2023
This reverts commit 1035a91. As reported by @FlorianFranzen [^1] and @miangraham [^2], this update breaks 9 packages, especially neomutt and framac. [^1] NixOS#246203 (comment) [^2] NixOS#247357 (comment)
AndersonTorres
force-pushed
the
emacs-update
branch
from
e6a486e
to
256b42d
Compare
AndersonTorres
added a commit
to atorres1985-contrib/nixpkgs
that referenced
this pull request
Aug 10, 2023
This reverts commit 1035a91. As reported by @FlorianFranzen [^1] and @miangraham [^2], this update breaks 9 packages, especially neomutt and framac. [^1] NixOS#246203 (comment) [^2] NixOS#247357 (comment)
AndersonTorres
force-pushed
the
emacs-update
branch
from
256b42d
to
77541f1
Compare
|
That being said, I will squash everything and unsquash later:
|
Also, move emacsMacport to aliases.nix.
AndersonTorres
force-pushed
the
emacs-update
branch
from
77541f1
to
9dafe35
Compare
Co-authored-by: Atemu <atemu.main@gmail.com> Co-authored-by: adisbladis <adisbladis@gmail.com> Co-authored-by: asymmetric <lorenzo@mailbox.org>
AndersonTorres
force-pushed
the
emacs-update
branch
from
9dafe35
to
46865e7
Compare
Atemu
approved these changes
Aug 11, 2023
|
Suggestion for the future: keep three major versions of Emacs in a queue fashion (oldest goes away, newest comes in) |
|
This is the status quo. In due time, someone will rip out emacs28. That's at least a few months off though. I wouldn't be opposed to keeping old versions around until they actually become a maintenance burden though. |
12 tasks
|
Let me suggest adding the Thanks for the bump! |
|
Ah, maybe a cherry-pick is better, since this PR touches the release notes of the next release, which not sure would be applicable to the previous release. |
|
Backport failed for Please cherry-pick the changes locally. git fetch origin release-23.05
git worktree add -d .worktree/backport-247357-to-release-23.05 origin/release-23.05
cd .worktree/backport-247357-to-release-23.05
git checkout -b backport-247357-to-release-23.05
ancref=$(git merge-base 7f65b7ca663050e6ec6612b465547a3fc35c6824 46865e7ab83e93a676dfd52bec3c4c591968ee09)
git cherry-pick -x $ancref..46865e7ab83e93a676dfd52bec3c4c591968ee09 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/current-status-of-emacs-29/31881/2 |
|
Remember myself to backport this, because of #249867 |
1 task
13 tasks
|
FYI, #270558 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Trying to catch #246203
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)