python310Packages.amazon-kclpy: rename from amazon_kclpy

[tjni]

Description of changes

Part of #245383.

This package doesn't properly build, and while the first error I encountered was easy to resolve, it was not obvious to me how to resolve the errors related to trying to download JARs from Maven Central. I don't think it should block this rename.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[natsukium]

The commit message is incorrect.
It should be python310Packages.new-attribute-name: rename from old_attribute_name.

[tjni]

The commit message is incorrect.

Whoops, you're right. I don't know what I was thinking.