Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.async-generator: rename from async_generator #248081

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 9, 2023

Description of changes

For #245383.

@adisbladis: Does this part in poetry2nix/default.nix need to change?

# Remove Python packages aliases with non-normalized names to avoid issues with infinite recursion (issue #750).
(self: super: {
  # Upstream nixpkgs uses non canonical names
  async-generator = super.async-generator or super.async_generator or null;
})

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member

@adisbladis: Does this part in poetry2nix/default.nix need to change?

# Remove Python packages aliases with non-normalized names to avoid issues with infinite recursion (issue #750).
(self: super: {
  # Upstream nixpkgs uses non canonical names
  async-generator = super.async-generator or super.async_generator or null;
})

I don't think it has to as we're using super and not self.
This shouldn't be a source of infinite recursion.

@natsukium
Copy link
Member

@ofborg build python310Packages.async-generator

@natsukium
Copy link
Member

Result of nixpkgs-review pr 248081 run on x86_64-linux 1

5 packages built:
  • nixops_unstable
  • python310Packages.async-generator
  • python310Packages.async-generator.dist
  • python311Packages.async-generator
  • python311Packages.async-generator.dist

@tjni
Copy link
Contributor Author

tjni commented Aug 9, 2023

@ofborg build python310Packages.async-generator

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@natsukium natsukium merged commit 07c5633 into NixOS:master Aug 10, 2023
21 checks passed
@tjni tjni deleted the async_generator branch August 10, 2023 00:28
@dotlambda
Copy link
Member

How come this caused rebuilds?

@tjni
Copy link
Contributor Author

tjni commented Aug 10, 2023

I'm not sure, probably because I changed the source to use SRI hash.

@dotlambda
Copy link
Member

No, the only actual rebuild is nixops_unstable. That's related to poetry2nix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants