Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nano: 2.8.0 -> 2.8.1 #24845

Merged
merged 1 commit into from
Apr 12, 2017
Merged

nano: 2.8.0 -> 2.8.1 #24845

merged 1 commit into from
Apr 12, 2017

Conversation

lsix
Copy link
Member

@lsix lsix commented Apr 12, 2017

See http://lists.gnu.org/archive/html/info-gnu/2017-04/msg00005.html
for release announcement

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@lsix, thanks for your PR! By analyzing the history of the files in this pull request, we identified @NeQuissimus, @copumpkin and @joachifm to be potential reviewers.

@NeQuissimus NeQuissimus merged commit ae002d6 into NixOS:master Apr 12, 2017
@copumpkin
Copy link
Member

This seems to have broken a load of stuff: http://hydra.nixos.org/build/51543644/nixlog/1

@copumpkin
Copy link
Member

Not sure if upstream changed the hash after release?

@joachifm
Copy link
Contributor

I get the same sha256 here (as the one used in the PR, that is); perhaps a transient error on Hydra? Bad mirror?

Also the changelog notes macos build fixes, has somebody looked into whether the darwin fixes are still necessary?

@copumpkin
Copy link
Member

copumpkin commented Apr 12, 2017

Yeah, I guess the hash is fine here too. Weird 😦

I just ran a test and the darwin-specific stuff (both pieces of conditional behavior) appears to be unnecessary now 😃

@copumpkin
Copy link
Member

@joachifm I just got rid of it in master 😄 thanks for pointing it out

@NeQuissimus
Copy link
Member

This is so weird... I just downloaded the archive from all mirrors and they are all good, that's not the issue... (and it is still the same as in the PR)

The only thing I can see is that the curl has a download size of 3246 (bytes?) at the bottom. That is way smaller than it should be... if the output is kB, it is way bigger than it should be (~1.3 MiB). I wonder if the 3246 byte file is a 404 or maybe that Cloudflare page you get every now and then when something is not available?!

@vcunat
Copy link
Member

vcunat commented Apr 14, 2017

Some transient error, probably. Hydra jobs are OK after restarting. It's unfortunate that some services just don't return error code correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants