nixos/pantheon, nixos/cinnamon: Drop qgnomeplatform #248544
Conversation
github-actions
bot
added
6.topic: nixos
8.has: module (update)
6.topic: pantheon
| qt.enable = true; | ||
| qt.platformTheme = "gnome"; | ||
| qt.style = "adwaita"; |
There was a problem hiding this comment.
Specifically for Cinnamon, @mkg20001 do you have a preference on whether this should default to fusion or gtk2? I am aware that Mint use gtk2 though this can look ugly if gtk2 theme is missing. I personally have no preference here.
There was a problem hiding this comment.
fusion is a gtk3 theme? or both and gtk2 is just a name? i would prefer a gtk3 theme, because its newer
There was a problem hiding this comment.
I think there is gtk3 the platformtheme in qtbase, I don't think this needs to be specified and you are all set if opening a Qt app uses your icon theme set in cinnamon-settings and opening a file from e.g. kate uses a native GTK file chooser.
But there is no gtk3 the style, I don't think Qt is willing to do it, the default style will be Fusion. Which means this cannot make your Qt apps look and feel matches your GTK theme.
The gtk2 platformtheme & style are third party projects, that can make Qt apps look and feel matches your GTK theme, but implementation will actually depend on gtk2.
There was a problem hiding this comment.
I don't feel qualified enough to give a last word, but the matching theme feature sounds nice.
There was a problem hiding this comment.
the matching theme feature sounds nice
Ugh, so to be clear shall we apply the gtk2 platformtheme & style by default or do you think asking users to do that in their NixOS config is okay? 😂 We actually should have fair reasons to do either
There was a problem hiding this comment.
by default sounds fine, maybe disable if other desktop environments are enabled
There was a problem hiding this comment.
maybe disable if other desktop environments are enabled
Not sure if I get your idea right, I think both gtk2 and fusion are used in at least one desktops right now I think (e.g. budgie for gtk2 and xfce for fusion).
There was a problem hiding this comment.
by default sounds fine
Okay I filed #249712
bobby285271
force-pushed
the
rm/qgnomeplatform
branch
from
2c760e1
to
68b5c53
Compare
bobby285271
force-pushed
the
rm/qgnomeplatform
branch
from
68b5c53
to
61b2db7
Compare
The upstream is not maintained, and qadwaitadecoration does not seem to be xorg-related. We should have proper shadows when using SSD.
The upstream is not maintained, and qadwaitadecoration does not seem to be xorg-related. We should have proper shadows when using SSD.
bobby285271
force-pushed
the
rm/qgnomeplatform
branch
from
61b2db7
to
ddd4973
Compare
Description of changes
#245166 (comment)
The upstream is officially not maintained, and qadwaitadecoration does not seem to be xorg-related. We should have proper shadows when using server side decoration.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)