nixos/nncp: add caller and daemon services #249175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Aug 28, 2023
| [](#opt-programs.nncp.settings) | ||
| ''; | ||
| socketActivation = { | ||
| enable = mkEnableOption '' |
There was a problem hiding this comment.
Sounds like a useful thing to have enabled by default, no?
There was a problem hiding this comment.
could be done later, I guess. Works otherwise.
There was a problem hiding this comment.
The socket activation is designed to work with UCSPI-TCP and not systemd, so I don't use it and haven't tested it well. I also run the daemon persistently for the sake of periodic multicast announcements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
We have
programs.nncpbut noservices.nncp.Things done