Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethercalc: use buildNpmPackage #249605

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dotlambda
Copy link
Member

Description of changes

See #229475

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member Author

@iblech Do you know what files I need to install to make this work? The standard install phase doesn't work.

@Lord-Valen
Copy link
Contributor

@iblech Do you know what files I need to install to make this work? The standard install phase doesn't work.

Pretty sure it's this: #245439

@dotlambda
Copy link
Member Author

@iblech Do you know what files I need to install to make this work? The standard install phase doesn't work.

Pretty sure it's this: #245439

No it's not. This happens in npmInstallHook.
@NixOS/node Why would I get

npm ERR! code ENOTCACHED
npm ERR! request to http://github.com/component/emitter/archive/1.0.1.tar.gz failed: cache mode is 'only-if-cached' but no cached response is available.

in npmInstallHook? It seems to be happening during npm prune.

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants