Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.numexpr: 2.8.4 -> 2.8.5 #249791

Closed
wants to merge 3 commits into from

Conversation

de11n
Copy link

@de11n de11n commented Aug 17, 2023

Description of changes

Upgrades numexpr. This, in particular, fixes numexpr in Nixpkgs when numpy is configured to use the MKL provider.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, version bump commits should be just that, so please factor out the other changes in separate commit(s).

@de11n
Copy link
Author

de11n commented Aug 18, 2023

@bjornfor Done!

@bjornfor
Copy link
Contributor

Result of nixpkgs-review pr 249791 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • python310Packages.elegy
  • python310Packages.elegy.dist
  • python311Packages.elegy
  • python311Packages.elegy.dist
60 packages failed to build:
  • openai-full
  • openai-full.dist
  • pentestgpt
  • pentestgpt.dist
  • python310Packages.apptools
  • python310Packages.apptools.dist
  • python310Packages.deepdish
  • python310Packages.deepdish.dist
  • python310Packages.envisage
  • python310Packages.envisage.dist
  • python310Packages.flammkuchen
  • python310Packages.flammkuchen.dist
  • python310Packages.langchain
  • python310Packages.langchain.dist
  • python310Packages.layoutparser
  • python310Packages.layoutparser.dist
  • python310Packages.mayavi
  • python310Packages.mayavi.dist
  • python310Packages.pandas-stubs
  • python310Packages.pandas-stubs.dist
  • python310Packages.pdfplumber
  • python310Packages.pdfplumber.dist
  • python310Packages.recordlinkage
  • python310Packages.recordlinkage.dist
  • python310Packages.scikit-survival
  • python310Packages.scikit-survival.dist
  • python310Packages.sfepy
  • python310Packages.sfepy.dist
  • python310Packages.stytra
  • python310Packages.stytra.dist
  • python310Packages.tables
  • python310Packages.tables.dist
  • python310Packages.unstructured-inference
  • python310Packages.unstructured-inference.dist
  • python311Packages.apptools
  • python311Packages.apptools.dist
  • python311Packages.deepdish
  • python311Packages.deepdish.dist
  • python311Packages.envisage
  • python311Packages.envisage.dist
  • python311Packages.flammkuchen
  • python311Packages.flammkuchen.dist
  • python311Packages.layoutparser
  • python311Packages.layoutparser.dist
  • python311Packages.mayavi
  • python311Packages.mayavi.dist
  • python311Packages.pandas-stubs
  • python311Packages.pandas-stubs.dist
  • python311Packages.pdfplumber
  • python311Packages.pdfplumber.dist
  • python311Packages.recordlinkage
  • python311Packages.recordlinkage.dist
  • python311Packages.scikit-survival
  • python311Packages.scikit-survival.dist
  • python311Packages.sfepy
  • python311Packages.sfepy.dist
  • python311Packages.tables
  • python311Packages.tables.dist
  • python311Packages.unstructured-inference
  • python311Packages.unstructured-inference.dist
4 packages built:
  • python310Packages.numexpr
  • python310Packages.numexpr.dist
  • python311Packages.numexpr
  • python311Packages.numexpr.dist

@natsukium
Copy link
Member

@ofborg build python310Packages.numexpr

@natsukium
Copy link
Member

This bump seems to break python310Packages.tables

tables> ======================================================================
tables> ERROR: None (tables.tests.test_queries.ScalarTableUsageTestCase)
tables> ----------------------------------------------------------------------
tables> Traceback (most recent call last):
tables>   File "/nix/store/zxv9vwfkaz2wd5a7bz2prmx5zm1gs88b-python3.10-tables-3.8.0/lib/python3.10/site-packages/tables/tests/test_queries.py", line 643, in test_unsupported_object
tables>     self.assertRaises(TypeError, self.table.where, '[]')
tables>   File "/nix/store/2c7sgx69p6mmp76cvmi5j6c72dj76jj8-python3-3.10.12/lib/python3.10/unittest/case.py", line 738, in assertRaises
tables>     return context.handle('assertRaises', args, kwargs)
tables>   File "/nix/store/2c7sgx69p6mmp76cvmi5j6c72dj76jj8-python3-3.10.12/lib/python3.10/unittest/case.py", line 201, in handle
tables>     callable_obj(*args, **kwargs)
tables>   File "/nix/store/zxv9vwfkaz2wd5a7bz2prmx5zm1gs88b-python3.10-tables-3.8.0/lib/python3.10/site-packages/tables/table.py", line 1458, in where
tables>     return self._where(condition, condvars, start, stop, step)
tables>   File "/nix/store/zxv9vwfkaz2wd5a7bz2prmx5zm1gs88b-python3.10-tables-3.8.0/lib/python3.10/site-packages/tables/table.py", line 1476, in _where
tables>     compiled = self._compile_condition(condition, condvars)
tables>   File "/nix/store/zxv9vwfkaz2wd5a7bz2prmx5zm1gs88b-python3.10-tables-3.8.0/lib/python3.10/site-packages/tables/table.py", line 1334, in _compile_condition
tables>     compiled = compile_condition(condition, typemap, indexedcols)
tables>   File "/nix/store/zxv9vwfkaz2wd5a7bz2prmx5zm1gs88b-python3.10-tables-3.8.0/lib/python3.10/site-packages/tables/conditions.py", line 393, in compile_condition
tables>     expr = ne.necompiler.stringToExpression(condition, typemap, {})
tables>   File "/nix/store/irywvhsb58b3ad0l2pgva425qhqn0w76-python3.10-numexpr-2.8.5/lib/python3.10/site-packages/numexpr/necompiler.py", line 274, in stringToExpression
tables>     raise ValueError(f'Expression {s} has forbidden control characters.')
tables> ValueError: Expression [] has forbidden control characters.
tables>
tables> ======================================================================
tables> ERROR: None (tables.tests.test_queries.ScalarTableUsageTestCase)
tables> ----------------------------------------------------------------------
tables> Traceback (most recent call last):
tables>   File "/nix/store/zxv9vwfkaz2wd5a7bz2prmx5zm1gs88b-python3.10-tables-3.8.0/lib/python3.10/site-packages/tables/tests/test_queries.py", line 650, in test_unsupported_syntax
tables>     self.assertRaises(TypeError, self.table.where, 'c_bool[0]')
tables>   File "/nix/store/2c7sgx69p6mmp76cvmi5j6c72dj76jj8-python3-3.10.12/lib/python3.10/unittest/case.py", line 738, in assertRaises
tables>     return context.handle('assertRaises', args, kwargs)
tables>   File "/nix/store/2c7sgx69p6mmp76cvmi5j6c72dj76jj8-python3-3.10.12/lib/python3.10/unittest/case.py", line 201, in handle
tables>     callable_obj(*args, **kwargs)
tables>   File "/nix/store/zxv9vwfkaz2wd5a7bz2prmx5zm1gs88b-python3.10-tables-3.8.0/lib/python3.10/site-packages/tables/table.py", line 1458, in where
tables>     return self._where(condition, condvars, start, stop, step)
tables>   File "/nix/store/zxv9vwfkaz2wd5a7bz2prmx5zm1gs88b-python3.10-tables-3.8.0/lib/python3.10/site-packages/tables/table.py", line 1476, in _where
tables>     compiled = self._compile_condition(condition, condvars)
tables>   File "/nix/store/zxv9vwfkaz2wd5a7bz2prmx5zm1gs88b-python3.10-tables-3.8.0/lib/python3.10/site-packages/tables/table.py", line 1334, in _compile_condition
tables>     compiled = compile_condition(condition, typemap, indexedcols)
tables>   File "/nix/store/zxv9vwfkaz2wd5a7bz2prmx5zm1gs88b-python3.10-tables-3.8.0/lib/python3.10/site-packages/tables/conditions.py", line 393, in compile_condition
tables>     expr = ne.necompiler.stringToExpression(condition, typemap, {})
tables>   File "/nix/store/irywvhsb58b3ad0l2pgva425qhqn0w76-python3.10-numexpr-2.8.5/lib/python3.10/site-packages/numexpr/necompiler.py", line 274, in stringToExpression
tables>     raise ValueError(f'Expression {s} has forbidden control characters.')
tables> ValueError: Expression c_bool[0] has forbidden control characters.
tables>
tables> ----------------------------------------------------------------------
tables> Ran 6702 tests in 1069.925s
tables>
tables> FAILED (errors=2, skipped=58)
error: builder for '/nix/store/82d1bpsp19dl12c17ssqxg0557qwyzds-python3.10-tables-3.8.0.drv' failed with exit code 1;

PyTables/PyTables#1046 seems to fix it.

@natsukium
Copy link
Member

I think we can patch with the above commit.

@wegank
Copy link
Member

wegank commented Jan 22, 2024

Done in 5368625.

@wegank wegank closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants